Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ommiting 0.0 values for hubbard #1029

Merged

Conversation

AndresOrtegaGuerrero
Copy link
Member

This PR solves #942

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.10%. Comparing base (219b06e) to head (2e6102b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/aiidalab_qe/app/configuration/advanced/model.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1029   +/-   ##
=======================================
  Coverage   69.10%   69.10%           
=======================================
  Files         117      117           
  Lines        6487     6487           
=======================================
  Hits         4483     4483           
  Misses       2004     2004           
Flag Coverage Δ
python-3.11 69.10% <0.00%> (ø)
python-3.9 69.11% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndresOrtegaGuerrero AndresOrtegaGuerrero merged commit 52865b6 into aiidalab:main Dec 23, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants