Sentence-case

[edan-bainglass]

This PR enforces sentence casing throughout the app.

Closes #987

[edan-bainglass]

@superstar54 please review the last commit

[edan-bainglass]

@superstar54 I'm trying to fix the failed test. Simple enough, just regenerate the summary reference. However, since upgrading to the latest image, I can no longer run tests locally 😞 First I was missing locate, which I installed as root via apt update & apt install locate. But now I get FileNotFoundError: 'pg_ctl' could not be found.

[edan-bainglass]

@superstar54 I'm trying to fix the failed test. Simple enough, just regenerate the summary reference. However, since upgrading to the latest image, I can no longer run tests locally 😞 First I was missing locate, which I installed as root via apt update & apt install locate. But now I get FileNotFoundError: 'pg_ctl' could not be found.

This is an issue with our stack. See here. For now, switching to the aiida-core-services environment allowed me to run the tests.

[edan-bainglass]

@superstar54 I'm trying to fix the failed test. Simple enough, just regenerate the summary reference. However, since upgrading to the latest image, I can no longer run tests locally 😞 First I was missing locate, which I installed as root via apt update & apt install locate. But now I get FileNotFoundError: 'pg_ctl' could not be found.

This is an issue with our stack. See here. For now, switching to the aiida-core-services environment allowed me to run the tests.

Also, the solution was not to regenerate. It's just that the test is looking for hard coded strings that this PR changed (made sentence-case). Fixed!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.58%. Comparing base (5ce2532) to head (1413a12).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1034   +/-   ##
=======================================
  Coverage   67.58%   67.58%           
=======================================
  Files         117      117           
  Lines        6488     6488           
=======================================
  Hits         4385     4385           
  Misses       2103     2103           

Flag	Coverage Δ
python-3.11	67.58% <100.00%> (ø)
python-3.9	67.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[edan-bainglass]

@superstar54 can you please have a quick look once the tests pass? 🙏

[superstar54]

can you please have a quick look once the tests pass?

The test failed. Seems need to change "From Example" to "From example"?

[superstar54]

Hi @edan-bainglass , LGTM! I approved. Please merge when the tests pass.

[edan-bainglass]

@superstar54 the docker build is now consistently failing with a timeout on test_qe_app_select_silicon_and_confirm. Can you have a look? Likely related to your From examples changes. I'll merge this one though, as it is unrelated.

[edan-bainglass]

@superstar54 the docker build is now consistently failing with a timeout on test_qe_app_select_silicon_and_confirm. Can you have a look? Likely related to your From examples changes. I'll merge this one though, as it is unrelated.

Ah, it IS this PR that is the cause of the failure. The test is looking for "From Examples", but this PR made it "From examples", so there we go. Okay, will fix in another PR.