fix: enable running image on Renku #1105
Conversation
|
Hi @olevski , thanks for the fix. I got this error when visit the link ( https://renkulab.io/v2/projects/jusong.yeu/aiidalab-qe-app.) you shared
|
|
From the name, seems the link (jusong.yeu/aiidalab-qe-app) is related to @unkcpz |
|
@superstar54 this project is owned by Jason and it is not public. That is why you get a 404 when you visit the link. He would have to add you to it to test. I was emailing with Jason back and forth. It is probably best that he reviews and tests this. I will email him and let him know and see how he wants to progress this. |
|
Yes, I have added @unkcpz as a reviewer. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
+ Coverage 70.92% 70.94% +0.01%
==========================================
Files 115 115
Lines 7158 7158
==========================================
+ Hits 5077 5078 +1
+ Misses 2081 2080 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Ok cool. I did not know Jason's handle. I will email him as well. @unkcpz ping! |
| cd /home/${NB_USER} && tar -cf /opt/conda/home.tar . | ||
| # NOTE: The work folder is empty but if included clashes with the work folder in a Renku | ||
| # session whose permissions cannot be changed. | ||
| cd /home/${NB_USER} && tar -cf /opt/conda/home.tar --exclude work . |
There was a problem hiding this comment.
Okay, we include the work from legacy jupyter, it is better to exclude it from the tar.
|
Thanks @olevski, when we start the aiidalab-qe on k8s, I also pass to the jupyterhub to start not using the lab but the notebook mode. How to pass this to the renku configuration? |
There was a problem hiding this comment.
Not sure where to make it by default the notebookapp mode, maybe it require to set the argument in the renku side before the container start?
I am trying:
Args: ["sh","-c","bash start.sh jupyter notebook --NotebookApp.ip=0.0.0.0 --NotebookApp.port=8888 --NotebookApp.base_url=$RENKU_BASE_URL_PATH --NotebookApp.token=\"\" --NotebookApp.password=\"\" --NotebookApp.allow_remote_access=true --ContentsManager.allow_hidden=true --NotebookApp.allow_origin=*"]
but it still start in the jupyterlab mode.
|
I am not sure what it's supposed to look like. Is it this? |
yes, exactly! I'll check what you changed in the setup. I think for the changes here it should all good. |
|
@unkcpz the only thing I changed is the If you open the Also @unkcpz I see that you are changing the session launcher I created. Also while I was editing it. So I am pretty sure now they are all in a weird state. |
Sorry, I was changing the url to open the home app directly. I think it works as I expected exactly, and I am able to manage more issues if there show up. I'll summarize and document it somewhere later. Thanks a lot for the help!! |
|
Ok great! I leave it up to you to click merge on this PR or redo it or whatever you want to do with it. |
|
@unkcpz just for completeness this is enough to open that notebook in the mode you wanted. But some more configuration on the jupyter side is needed in order for the app to fully run. It complains that it cannot find the kernel.
|
This enables running the image on Renku.
See the
qe-test-taskosession launcher on https://renkulab.io/v2/projects/jusong.yeu/aiidalab-qe-app.The session launcher has the following specs:
