Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nglview not show #1130

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

superstar54
Copy link
Member

I am testing the app inside normal notebooks, and this PR fixes:

  • nglview not show in step 1 and step 4
  • cutoffs are wrong in pseudo

Copy link
Member

@edan-bainglass edan-bainglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @superstar54. LGTM! Good catch on the cutoffs issue 💪

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.01%. Comparing base (4dd3741) to head (2f3958e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aiidalab_qe/app/structure/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1130   +/-   ##
=======================================
  Coverage   72.01%   72.01%           
=======================================
  Files         105      105           
  Lines        6871     6876    +5     
=======================================
+ Hits         4948     4952    +4     
- Misses       1923     1924    +1     
Flag Coverage Δ
python-3.11 72.01% <87.50%> (+<0.01%) ⬆️
python-3.9 72.01% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 59e3c75 into aiidalab:main Feb 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants