Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reminder_text #683

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Apr 24, 2024

Only observe to update the reminder_text if there is a setting panel.

@@ -89,6 +89,7 @@ def __init__(self, **kwargs):
value="moderate",
)
self.properties = {}
self.reminder_texts = {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about reminder_info ? what do you think ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, it works for me. I changed it to reminder_info.

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@superstar54 superstar54 merged commit cbc0023 into aiidalab:main Apr 25, 2024
14 checks passed
@superstar54 superstar54 deleted the fix_example_structure branch April 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants