Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/warning long calc #840

Merged
merged 9 commits into from
Oct 8, 2024

Conversation

mikibonacci
Copy link
Member

This fixes #816.

The check and the message were already there, but not triggered/shown.
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.32%. Comparing base (14e5009) to head (9071378).
Report is 89 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
+ Coverage   68.07%   68.32%   +0.24%     
==========================================
  Files          50       50              
  Lines        4561     4568       +7     
==========================================
+ Hits         3105     3121      +16     
+ Misses       1456     1447       -9     
Flag Coverage Δ
python-3.11 68.32% <100.00%> (+0.24%) ⬆️
python-3.9 68.35% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mikibonacci and others added 3 commits October 7, 2024 10:58
- not on localhost but big system and CPUs<4
- same as above, but on localhost
- on localhost and more than 1 CPUs (we may not have enough slots)
@mikibonacci mikibonacci marked this pull request as ready for review October 7, 2024 14:33
@mikibonacci
Copy link
Member Author

Hi @AndresOrtegaGuerrero and @superstar54 , the PR is ready for review.

In the submission step, I added (completed what I already found there) checks for: number of sites (lower than 10 is safe), cell volume (lower then 1000 A^3 is safe) and number of cpus (lower than 4 is not safe for big systems - see previous checks and Figure 1 - higher than 1 in localhost ask for checks, see Figure 2)
Figure 1 (similar warning even if not in localhost - see the code) is:
Screenshot 2024-10-07 at 16 30 53

Figure 2 is:
Screenshot 2024-10-07 at 16 32 10

@AndresOrtegaGuerrero
Copy link
Member

you have some issues in the tests, @mikibonacci is it possible to create a test , to check this logic ?

@mikibonacci
Copy link
Member Author

Hi @AndresOrtegaGuerrero, yeah will put some test, should be possible

@AndresOrtegaGuerrero
Copy link
Member

AndresOrtegaGuerrero commented Oct 7, 2024

What about for the structure ,
Warning: The selected structure has a large number of atoms ({num_sites}) or a significant cell volume ({int(volume)} Å<sup>3</sup>), making it computationally demanding to run at the localhost. Consider the following:

@mikibonacci
Copy link
Member Author

Hi @AndresOrtegaGuerrero , I updated the descriptions. For the tests: I added the testing for the localhost part, not for the non-localhost (I am not sure how to do it, as we should load an external code...). Let me know if you have some ideas on how to do it, or if we can go like this.

thanks!

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Miki

@mikibonacci mikibonacci merged commit 6101655 into aiidalab:main Oct 8, 2024
8 checks passed
@mikibonacci mikibonacci deleted the features/warning_long_calc branch October 8, 2024 13:29
edan-bainglass added a commit to edan-bainglass/aiidalab-qe that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show warning messages if the calculation takes too long time
2 participants