Move spin orbit to basic settings #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage 68.55% 68.55%
=======================================
Files 111 111
Lines 6307 6307
=======================================
Hits 4324 4324
Misses 1983 1983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mikibonacci
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Hi @edan-bainglass, thank you for the work, looks nice and indeed makes sense to have the SoC in the basics.
LGTM!
edan-bainglass
force-pushed
the
spin-orbit-in-basic
branch
from
72c4819 to
369f4e6
Compare
edan-bainglass
force-pushed
the
spin-orbit-in-basic
branch
from
369f4e6 to
4c54fa2
Compare
edan-bainglass
added a commit
that referenced
this pull request
Jan 19, 2025
) #984 neglected to address this. The hack ensures that when a process is loaded, the unpacked parameters applied to `spin_orbit` in the advanced model are synchronized with the basic model (and UI by observation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the spin orbit control from advanced to basic settings. It also simplifies/uniforms the basic settings UI.
Closes #981