Skip to content

Commit

Permalink
r-daniel
Browse files Browse the repository at this point in the history
  • Loading branch information
unkcpz committed Feb 23, 2024
1 parent b8eead7 commit 4bbb55d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ jobs:

strategy:
matrix:
tag: [latest]
python-version: ['3.9', '3.10']
aiida-core-version: [2.2.2, 2.4.3] # test on the latest and the oldest supported version
fail-fast: false
Expand Down Expand Up @@ -142,8 +141,6 @@ jobs:

- name: Run pytest
run: pytest -v tests --cov
env:
TAG: ${{ matrix.tag }}

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
Expand Down
11 changes: 5 additions & 6 deletions tests_notebooks/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@ version: '3.4'
services:

aiidalab:
# TODO: after the oldest aiida-core supported version is v2.4.0,
# move to use ghcr.io registry to pull the image, the dockerhub registry has
# a rate limit of 100 pulls per 6 hours.
# aiida-core < 2.4.0 is not push to ghcr.io because of CI issues
# The CI is fixed in https://github.com/aiidalab/aiidalab-docker-stack/pull/390 and
# from aiida-core 2.4.0 the images are pushed to ghcr.io.
# TODO: When we drop support of images with aiida-core<2.4.0, we should go back to using
# the ghcr.io registry to pull the image,
# since the dockerhub registry has a rate limit of 100 pulls per 6 hours.
# Images with aiida-core<2.4.0 were not pushed to ghcr.io because of CI issues,
# which were fixed in https://github.com/aiidalab/aiidalab-docker-stack/pull/390
image: aiidalab/full-stack:${TAG:-latest}
environment:
RMQHOST: messaging
Expand Down

0 comments on commit 4bbb55d

Please sign in to comment.