🧪 EpwParser: reintroduce tests from AiiDA-QE
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notes:
|
mbercx
force-pushed
the
tests/add-parser
branch
2 times, most recently
from
9be0ff9 to
9f82330
Compare
ymzhang0
approved these changes
Nov 5, 2025
|
Ah, I just realised you already approved the PR when giving your comments. ^^ I suppose since you marked the second comment as resolved, I can go ahead and merge? Will already rebase. |
mbercx
force-pushed
the
tests/add-parser
branch
from
7603311 to
801f8f6
Compare
Add the parser tests that were previously in the EPW support branch of `aiida-quantumespresso`. For setting up a `localhost` computer, we rely on the `aiida_localhost` test fixture provided in the `aiida.tools.pytest_fixtures` module, made available via the `pytest_plugins` variable. Originally the idea was to make the `aiida-quantumespresso` fixtures similarly importable, but closer inspection revealed improvements can still be made, and the fixtures were currently not general enough to work for other plugin packages. Instead, we add two fixtures here: - `files_path`: this simply returns the path to the test files directory. For the tests added here, the files correspond to the output files for which we want to test the `EpwParser`. - `parse_from_files`: a simplified version of the fixtures defined in `aiida-quantumespresso`. Parses the output files in the corresponding `test_name` directory. The tests that we had in the EPW support branch have also been adapted to rely on these fixtures.
mbercx
force-pushed
the
tests/add-parser
branch
from
801f8f6 to
e6d6ce4
Compare
|
There. Also squashed the commits into one final commit that I will then add to |
|
Yes. I just had a look at the changes. think the tests are quite good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the parser tests that were previously in the EPW support branch of
aiida-quantumespresso.For setting up a
localhostcomputer, we rely on theaiida_localhosttest fixture provided in theaiida.tools.pytest_fixturesmodule, made available via thepytest_pluginsvariable. Originally the idea was to make theaiida-quantumespressofixtures similarly importable, but closer inspection revealed improvements can still be made, and the fixtures were currently not general enough to work for other plugin packages.Instead, we add two fixtures here:
files_path: this simply returns the path to the test files directory. For the tests added here, the files correspond to the output files for which we want to test theEpwParser.parse_from_files: a simplified version of the fixtures defined inaiida-quantumespresso. Parses the output files in the correspondingtest_namedirectory.The tests that we had in the EPW support branch have also been adapted to rely on these fixtures.