-
Notifications
You must be signed in to change notification settings - Fork 201
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove superfluous _validate from Data node
The Data nodeclass overwrote the `_validate` function but (a) did no validation (b) included commented code that referenced a private git repository (c) returned `None` instead of `True`. The outcommented code involved validation of the `source` attribute and the referenced issue pointed out that the value of this attribute was not officially standardized (potentially leading users to using it in different ways). Since there has not been validation of this field since 2015, it seems safe to assume that it cannot be easily reintroduced at this point.
- Loading branch information
Showing
2 changed files
with
8 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters