Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly released matplotlib 3.5.0 breaks tests #5231

Closed
csadorf opened this issue Nov 17, 2021 · 0 comments · Fixed by #5233
Closed

Newly released matplotlib 3.5.0 breaks tests #5231

csadorf opened this issue Nov 17, 2021 · 0 comments · Fixed by #5233

Comments

@csadorf
Copy link
Contributor

csadorf commented Nov 17, 2021

Matplotlib just released version 3.5.0 which breaks tests specifically this one:

@pytest.mark.usefixtures('clear_database_before_test')
def test_data_exporters(data_plugin, generate_class_instance):
"""Verify that the return value of the export methods of all `Data` sub classes have the correct type.
It should be a tuple where the first should be a byte string and the second a dictionary.
"""
export_formats = data_plugin.get_export_formats()
if not export_formats:
return
instance = generate_class_instance(data_plugin)
for fileformat in export_formats:
content, dictionary = instance._exportcontent(fileformat) # pylint: disable=protected-access
assert isinstance(content, bytes)
assert isinstance(dictionary, dict)

@csadorf csadorf self-assigned this Nov 17, 2021
csadorf added a commit that referenced this issue Nov 17, 2021
csadorf added a commit that referenced this issue Nov 17, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Deprecated as of version 3.3.4, see:
https://matplotlib.org/3.3.4/api/api_changes.html#text-latex-preview-rcparam

Requires matplotlib~=3.3,>=3.3.4.

Fixes #5231.
csadorf added a commit that referenced this issue Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant