Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add echo_deprecated function #1648

Merged
merged 5 commits into from
Jun 18, 2018
Merged

add echo_deprecated function #1648

merged 5 commits into from
Jun 18, 2018

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Jun 18, 2018

  • add cmdline.utils.echo.echo_deprecated
  • add standard error codes
  • remove 'prefix' option from the echo commands

@ltalirz
add echo_deprecated function
624b8bf 
 * add cmdline.utils.echo.echo_deprecated
 * add standard error codes
 * remove 'prefix' option from the echo commands
@ltalirz ltalirz requested a review from giovannipizzi June 18, 2018 09:21
@ltalirz
fix help strings
a14d629 
 * replace 'EXIT: ' by 'Exit: ' for consistency
@ltalirz ltalirz requested a review from sphuber June 18, 2018 09:29
@codecov-io
Copy link

codecov-io commented Jun 18, 2018 •
edited
Loading

Codecov Report

Merging #1648 into verdi will increase coverage by 0.03%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##            verdi    #1648      +/-   ##
==========================================
+ Coverage   59.11%   59.14%   +0.03%     
==========================================
  Files         294      294              
  Lines       34525    34526       +1     
==========================================
+ Hits        20411    20422      +11     
+ Misses      14114    14104      -10
Impacted Files Coverage Δ
aiida/cmdline/utils/templates.py 100% <ø> (ø) ⬆️
aiida/cmdline/commands/work.py 74.77% <0%> (-0.34%) ⬇️
aiida/cmdline/utils/multi_line_input.py 92.59% <100%> (ø) ⬆️
aiida/cmdline/commands/rehash.py 89.65% <100%> (+0.36%) ⬆️
aiida/cmdline/utils/echo.py 80.64% <77.77%> (+5.64%) ⬆️
aiida/backends/djsite/db/models.py 76.23% <0%> (+0.88%) ⬆️
aiida/backends/djsite/globalsettings.py 86.84% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 581f328...a5d1f6e. Read the comment docs.

sphuber
sphuber previously approved these changes Jun 18, 2018
View reviewed changes
@sphuber sphuber merged commit 18c1718 into aiidateam:verdi Jun 18, 2018
@giovannipizzi giovannipizzi mentioned this pull request Jun 18, 2018
Closed
@ltalirz ltalirz deleted the add_deprecated_echo branch August 28, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

@giovannipizzi giovannipizzi Awaiting requested review from giovannipizzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ltalirz @codecov-io @sphuber