Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sudo pwd prompt in quicksetup #1734

Merged
merged 4 commits into from
Jul 20, 2018

Conversation

DropD
Copy link
Contributor

@DropD DropD commented Jul 9, 2018

Was broken by running the command in a new process group, as detailed in #1535.

@DropD DropD requested review from muhrin and greschd July 9, 2018 15:00
@codecov-io
Copy link

codecov-io commented Jul 9, 2018

Codecov Report

Merging #1734 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1734      +/-   ##
===========================================
- Coverage    57.16%   57.13%   -0.03%     
===========================================
  Files          275      275              
  Lines        33912    33912              
===========================================
- Hits         19386    19377       -9     
- Misses       14526    14535       +9
Impacted Files Coverage Δ
aiida/control/postgres.py 90.9% <100%> (ø) ⬆️
aiida/backends/djsite/globalsettings.py 81.57% <0%> (-5.27%) ⬇️
aiida/backends/djsite/db/models.py 75.09% <0%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75473e7...ce5593e. Read the comment docs.

Was broken by running the command in a new process group
@DropD DropD force-pushed the fix-quicksetup-pwd-prompt branch from 2d17ea0 to d81f2d7 Compare July 10, 2018 10:25
Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine there is no simple way to test this, right?
Just to make sure, was this tested at least once? If the answer is yes, then I'm ok to merge (I'm already approving this)

@DropD
Copy link
Contributor Author

DropD commented Jul 13, 2018 via email

@sphuber sphuber merged commit e98f3f9 into aiidateam:develop Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants