-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix sudo pwd prompt in quicksetup #1734
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1734 +/- ##
===========================================
- Coverage 57.16% 57.13% -0.03%
===========================================
Files 275 275
Lines 33912 33912
===========================================
- Hits 19386 19377 -9
- Misses 14526 14535 +9
Continue to review full report at Codecov.
|
Was broken by running the command in a new process group
2d17ea0
to
d81f2d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine there is no simple way to test this, right?
Just to make sure, was this tested at least once? If the answer is yes, then I'm ok to merge (I'm already approving this)
It has been tested locally.
Testing it would require running it as a non-super user with no
passwordless postgres rights. Next it would require interaction to either
input the sudo password or terminate the process. It is not impossible, but
not simple either.
…On Fri, Jul 13, 2018, 07:55 Giovanni Pizzi ***@***.***> wrote:
***@***.**** approved this pull request.
I imagine there is no simple way to test this, right?
Just to make sure, was this tested at least once? If the answer is yes,
then I'm ok to merge (I'm already approving this)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1734 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMqBKlRqrdsQe6UGWd_mjd4rQx1HWVrks5uGDZegaJpZM4VH3fE>
.
|
Was broken by running the command in a new process group, as detailed in #1535.