Enable CI on Github #3571

sphuber · 2019-11-25T18:22:23Z

I did not touch the files for the Jenkins tests yet. I want to see what it is exactly that we want to run there and if possible simplify the scripts and remove what we no longer need. The current setup also does not include coverage yet.

To move the CI to GitHub actions, I created a workflow .github/workflows/ci.yml.
This defines 5 different actions:

conda: will run .github/workflows/conda.sh to install conda and create the environment from environment.yml
docs: will build the documentation
pre-commit: runs pre-commit on all the files
tests: runs .github/workflows/tests.sh to run all tests for both backends, for now only for python 3.7 but other versions can easily be added in the matrix. The tests include the entire unit test suite through verdi devel tests as well as the various stand alone tests in .ci
verdi: tests the loading speed of verdi

The reason I put the actions in separate actions is that many of them do not require the same setup and like this they will run in parallel making the total run time shorter. I also feel that the files are clearer this way and it is easier to understand what is going on and what actions is responsible for what. The only downside of this approach is if we would run out of actions slots, but it seems there is only a limit on number of concurrent workflows, which at 20 per repository I don't think we will hit very often.

Finally, to simplify the configuration of profiles, computer and codes for the tests action, I have created .yaml configuration files in .github/config which are called in .github/workflows/setup.sh.

.github/workflows/ci.yml

ltalirz

Thanks a lot @sphuber for all the work, this is great!

Since there are quite a few new files, could you perhaps describe in a few words what has changed?
That would make a detailed review a bit quicker.

sphuber · 2019-11-25T21:54:03Z

@ltalirz just added an overview, let me know if something is still missing.

ltalirz

Overall looks good to me, some minor suggestions

.ci/test_process.py

.github/config/doubler.yaml

.github/workflows/conda.sh

.github/workflows/ci.yml

.github/workflows/tests.sh

setup.json

sphuber · 2019-11-26T10:38:46Z

@ltalirz I think the current state then is ready. I will then add a commit to remove Travis and simplify the remaining code necessary to run on Jenkins

sphuber · 2019-11-26T12:49:56Z

This is essentially ready. Once we have released 1.0.1 and then merged PR #3566 into develop this can be rebased. We can then turn of Travis as required checks and enable the new GitHub workflow. The only remaining differences with the current situation:

Coverage has been removed: I vote that we try to move our unit testing to pytest soon and then use the coverage plugin. This should solve quite a few issues that are currently open related to coverage.
Transifex: this deploy trigger is not yet ported
PyPI release: this deploy trigger is also not yet ported, but I want to do this separately to make sure it works well.

Add a GitHub workflow `.github/workflows/ci.yml` that will trigger on push and pull requests. It will run the five actions it defines: * `conda`: will install conda and create the environment * `docs`: builds the documentation with nitpick warning * `pre-commit`: runs pre-commit on all files * `tests`: runs `verdi devel tests` and the stand alone test files * `verdi`: runs the tests that check the load time is acceptable All tests are performed for python 3.7 except for the `tests` action that is done for 3.5 as well. Both python versions are run for both database backends in a matrix strategy. Even though we support 3.6 as well we do not explicitly test it since it will require another two builds and testing 3.5 and 3.7 should give decent guarantees. Finally the argument for multiple individual actions instead of joining them is based on the fact that there does not seem to be a limit on concurrent number of actions on GitHub as of this writing. This means that by spreading them out, allows running them in parallel which should reduce the overal runtime of the continuous integration workflow.

sphuber · 2019-12-02T17:02:43Z

@ltalirz with v1.0.1 released, python 2 dropped, this PR rebased, it is now ready to go!

sphuber · 2019-12-02T17:03:18Z

GitHub workflow run can be found here:https://github.com/sphuber/aiida_core/commit/64c63ad75dd3821c02ed2ad4b813140f7bad68e8/checks?check_suite_id=338130505

The majority of tests are now run through a GitHub CI workflow. This means it is not necessary to also run those on Jenkins, especially that Jenkins was originally configured to just run additional tests that were more computationally intensive. Therefore, we only keep the RPN test to run on Jenkins for now.

ltalirz

thanks @sphuber , I've gone through everything and looks good to go!

ltalirz · 2019-12-03T17:16:22Z

.github/workflows/ci.yml

+      run:
+        .github/workflows/tests.sh
+
+  verdi:


still seems like a bit of a waste to do all of the installation just to run one test...
anyhow, it's fine for now

Let's bask in the superfluous wealth of practically unlimited parallel builds :)

sphuber requested review from giovannipizzi and ltalirz November 25, 2019 18:22

sphuber mentioned this pull request Nov 25, 2019

[WIP]Add continious integration workflow for GitHub #3554

Closed

sphuber force-pushed the fix_3553_github_ci branch 4 times, most recently from 2f588e1 to dee017d Compare November 25, 2019 20:40

ltalirz reviewed Nov 25, 2019

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

ltalirz reviewed Nov 25, 2019

View reviewed changes

sphuber force-pushed the fix_3553_github_ci branch 2 times, most recently from 3eb6d19 to e90914d Compare November 26, 2019 07:03

sphuber force-pushed the fix_3553_github_ci branch 7 times, most recently from 1aa77e3 to cdef5de Compare November 26, 2019 12:12

sphuber marked this pull request as ready for review November 26, 2019 12:46

giovannipizzi mentioned this pull request Dec 1, 2019

fix gotocomputer when key_filename missing #3593

Merged

sphuber force-pushed the fix_3553_github_ci branch 2 times, most recently from 42b2d77 to 00fb5d7 Compare December 2, 2019 16:52

sphuber force-pushed the fix_3553_github_ci branch from 00fb5d7 to 64c63ad Compare December 2, 2019 16:55

sphuber requested a review from ltalirz December 2, 2019 17:02

sphuber force-pushed the fix_3553_github_ci branch from 64c63ad to fab1c56 Compare December 3, 2019 10:35

sphuber mentioned this pull request Dec 3, 2019

Cleanup dependencies #3597

Merged

ltalirz approved these changes Dec 3, 2019

View reviewed changes

sphuber merged commit 1a1da24 into aiidateam:develop Dec 3, 2019

sphuber deleted the fix_3553_github_ci branch December 3, 2019 18:40

sphuber mentioned this pull request Dec 4, 2019

Reinstate coverage to CI when testing is migrated to pytest #3602

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable CI on Github #3571

Enable CI on Github #3571

sphuber commented Nov 25, 2019 •

edited

Loading

ltalirz left a comment

sphuber commented Nov 25, 2019

ltalirz left a comment

sphuber commented Nov 26, 2019

sphuber commented Nov 26, 2019

sphuber commented Dec 2, 2019

sphuber commented Dec 2, 2019

ltalirz left a comment •

edited

Loading

ltalirz Dec 3, 2019

sphuber Dec 3, 2019

Enable CI on Github #3571

Enable CI on Github #3571

Conversation

sphuber commented Nov 25, 2019 • edited Loading

ltalirz left a comment

Choose a reason for hiding this comment

sphuber commented Nov 25, 2019

ltalirz left a comment

Choose a reason for hiding this comment

sphuber commented Nov 26, 2019

sphuber commented Nov 26, 2019

sphuber commented Dec 2, 2019

sphuber commented Dec 2, 2019

ltalirz left a comment • edited Loading

Choose a reason for hiding this comment

ltalirz Dec 3, 2019

Choose a reason for hiding this comment

sphuber Dec 3, 2019

Choose a reason for hiding this comment

sphuber commented Nov 25, 2019 •

edited

Loading

ltalirz left a comment •

edited

Loading