Build docker image based on aiida-prerequisites

[yakutovicha]

fixes #3725

[ltalirz]

For the record, this is an implementation of the discussion on the plugin testing infrastructure from the coding week (document now frozen).

[ltalirz]

thanks @yakutovicha !

one comment + please add a job to build the docker file here

[sphuber]

Some minor comments

[yakutovicha]

I will now work on adding things to github workflows. @ltalirz and @sphuber please look at the changes in the meanwhile and see if you agree

[yakutovicha]

Btw, I think it totally makes sense to move the whole profile setup to quicksetup. What do you guys think?

[yakutovicha]

@sphuber can you help me in setting up Git Hub actions? I am not sure how to do things right. The manual suggests making a new action file. Is it the way to go?

[sphuber]

@sphuber can you help me in setting up Git Hub actions? I am not sure how to do things right. The manual suggests making a new action file. Is it the way to go?

What is it that needs to be run and when? Every commit? Take a look at the .github/workflows/ci.yml. There you will find the main job defined with the various steps that are run on each commit and PR. Depending on what you need to run, you can add one there.

[ltalirz]

What is it that needs to be run and when? Every commit?

The build of the docker image should be run on every commit

[yakutovicha]

What is it that needs to be run and when? Every commit?

It should be docker build, yes, it should be run every commit.

Take a look at the .github/workflows/ci.yml. There you will find the main job defined with the various steps that are run on each commit and PR.

I did it, and the check that I've added have failed. https://github.com/aiidateam/aiida-core/pull/3722/checks?check_run_id=405089491

[sphuber]

I did it, and the check that I've added have failed. https://github.com/aiidateam/aiida-core/pull/3722/checks?check_run_id=405089491

##[error]Process completed with exit code 100.
Run apt-get install -y --no-install-recommends docker.io
E: Could not open lock file /var/lib/dpkg/lock-frontend - open (13: Permission denied)
E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), are you root?

You are not installing with sudo, so try to prepend your install statements with sudo. Also I noticed that in the actual docker build step you do not specify the location of the Dockerfile. Is it going to find it automatically?

[yakutovicha]

btw, another option would be to add Docker hub status check. That requires no setup here. What do you guys think?

[yakutovicha]

You are not installing with sudo, so try to prepend your install statements with sudo.

Let's try. I wasn't sure if it is allowed to use sudo here.

Also I noticed that in the actual docker build step you do not specify the location of the Dockerfile. Is it going to find it automatically?

By default, it takes it from the current folder. I hope the current folder here is the package's root.

[ltalirz]

btw, another option would be to add Docker hub status check. That requires no setup here. What do you guys think?

I think that is a good idea. We should not require it to pass, since I believe this can take some time. But it's good to take burden away from github actions, and the build on dockerhub will be needed anyhow.

[ltalirz]

thanks @yakutovicha !

Looks all good to me - the requests are just typos etc.

[yakutovicha]

I think it's ready. @ltalirz or @sphuber please review.

[ltalirz]

thanks for the updates @yakutovicha !

I notice two issues with the actions build:

1. It seems like there is no profile configured, although by your default there should be
2. The docker build did not fail despite no profile being configured. I guess you should replace the verdi profile list by a verdy profile show default

[yakutovicha]

thanks for the updates @yakutovicha !

I notice two issues with the actions build:

1. It seems like [there is no profile configured](https://github.com/aiidateam/aiida-core/pull/3722/checks?check_run_id=405794933#step:5:6), although by your default there should be

2. The docker build did not fail despite no profile being configured. I guess you should replace the `verdi profile list` by a `verdy profile show default `

I think I know why let me try to fix that.

[yakutovicha]

Should be fixed with that: aiidateam/aiida-prerequisites#6. Let's see...

[ltalirz]

thanks @yakutovicha ! From my side this is good to go.

@sphuber : Somehow it looks to me like every actions check ran twice (not jenkins)

Not sure whether this is expected - anyhow I don't see how this PR should be responsible for it.

[sphuber]

Thanks @yakutovicha almost there: just two small fixes and a suggestion

[sphuber]

Oh and one final question: why is the Dockerfile on the top level? Since there is a .docker folder, doesn't it make more sense to put it in there? Or is that technically not possible or against convention?

[ltalirz]

Oh and one final question: why is the Dockerfile on the top level? Since there is a .docker folder, doesn't it make more sense to put it in there? Or is that technically not possible or against convention?

It is sort of a convention in that this is the place where many external tools/services will look for the Dockerfile by default (mybinder, heroku, Dockerhub, etc.).
It is possible to move it to the .docker folder but I think it's not a bad idea to have this one at the top level.

[yakutovicha]

@sphuber if you want to merge the PR, please let me know 5 mins in advance: I will set up automated builds on Docker Hub.

[sphuber]

OK this is good to go, let me know when you have setup Docker Hub and I will merge

[yakutovicha]

OK this is good to go, let me know when you have setup Docker Hub and I will merge

ready, please merge. Docker build should now be triggered automatically at Docker Hub: https://hub.docker.com/repository/docker/aiidateam/aiida-core

[sphuber]

Thanks @yakutovicha