Write migrated config to disk in Config.from_file
#3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an existing configuration file with an outdated schema was loaded from disk through `Config.from_file`, as happens in the initialization call of `aiida.manage.configuration.load_config`, the content was properly migrated in memory but the changes were not written to file. This caused the migration to be performed each time.
greschd
approved these changes
Feb 24, 2020
You assume correctly 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3790 and supersedes #3792
When an existing configuration file with an outdated schema was loaded
from disk through
Config.from_file, as happens in the initializationcall of
aiida.manage.configuration.load_config, the content wasproperly migrated in memory but the changes were not written to file.
This caused the migration to be performed each time.