Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: How to run external codes #4114

Merged
merged 10 commits into from
May 27, 2020

Conversation

ramirezfranciscof
Copy link
Member

@ramirezfranciscof ramirezfranciscof commented May 25, 2020

Fixes #3987

Added content to the section on how to run codes. Indeed this ended up being much more direct than the other section. Here I am actually worried you might ask me to add more stuff to it.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramirezfranciscof , I have some suggestions.

docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
@csadorf
Copy link
Contributor

csadorf commented May 26, 2020

Resolves #3987 .

@csadorf csadorf linked an issue May 26, 2020 that may be closed by this pull request
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Show resolved Hide resolved
docs/source/howto/codes.rst Show resolved Hide resolved
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
@csadorf
Copy link
Contributor

csadorf commented May 26, 2020

@ramirezfranciscof Is this ready for another round of review? If yes, please re-request it, thx.

@ramirezfranciscof
Copy link
Member Author

@csadorf Hey, not yet, I was waiting on the replies for the comments, there is one left I need to address.

@ramirezfranciscof
Copy link
Member Author

Now it is ready =D

@ramirezfranciscof ramirezfranciscof requested a review from csadorf May 26, 2020 11:53
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Almost ready to merge. :)

docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Show resolved Hide resolved
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
@ramirezfranciscof ramirezfranciscof requested a review from csadorf May 26, 2020 18:38
@ramirezfranciscof
Copy link
Member Author

@csadorf So, not sure if with the re-request suffices or I also needed to comment-ping you, so I'll do it just in case: changes applied, ready to review / squash in.

@sphuber
Copy link
Contributor

sphuber commented May 27, 2020

@ramirezfranciscof I will try to give a review this afternoon

@csadorf
Copy link
Contributor

csadorf commented May 27, 2020

@csadorf So, not sure if with the re-request suffices or I also needed to comment-ping you, so I'll do it just in case: changes applied, ready to review / squash in.

Just re-requesting is sufficient.

docs/source/howto/codes.rst Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
@ramirezfranciscof ramirezfranciscof requested a review from csadorf May 27, 2020 14:19
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramirezfranciscof , just a few remaining small things and then it is ok for me to merge

docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Outdated Show resolved Hide resolved
docs/source/howto/codes.rst Show resolved Hide resolved
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 @sphuber Please merge at your discretion.

@ramirezfranciscof ramirezfranciscof requested a review from sphuber May 27, 2020 16:17
@sphuber sphuber merged commit 253e8df into aiidateam:docs-revamp May 27, 2020
csadorf added a commit that referenced this pull request May 29, 2020
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
@ramirezfranciscof ramirezfranciscof deleted the docs-revamp-3987 branch December 11, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: How to run external codes
3 participants