-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: How to run external codes #4114
Docs: How to run external codes #4114
Conversation
19185be
to
2f63a58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ramirezfranciscof , I have some suggestions.
Resolves #3987 . |
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
@ramirezfranciscof Is this ready for another round of review? If yes, please re-request it, thx. |
@csadorf Hey, not yet, I was waiting on the replies for the comments, there is one left I need to address. |
Now it is ready =D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Almost ready to merge. :)
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com>
@csadorf So, not sure if with the re-request suffices or I also needed to comment-ping you, so I'll do it just in case: changes applied, ready to review / squash in. |
@ramirezfranciscof I will try to give a review this afternoon |
Just re-requesting is sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ramirezfranciscof , just a few remaining small things and then it is ok for me to merge
Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 @sphuber Please merge at your discretion.
Co-authored-by: Carl Simon Adorf <carl.simon.adorf@gmail.com> Co-authored-by: Sebastiaan Huber <mail@sphuber.net>
Fixes #3987
Added content to the section on how to run codes. Indeed this ended up being much more direct than the other section. Here I am actually worried you might ask me to add more stuff to it.