Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: install default postgresql instead of specific version #4860

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Apr 16, 2021

The CI configuration uses ubuntu-latest which recently became Ubuntu
Focal Fossa (20.04) which no longer has postgresql-10 available, but
instead provides postgres-12. Here we switch to using the default
postgresql, which is line with our installation guide and works with both
versions of Ubuntu.

The CI configuration uses `ubuntu-latest` which recently became Ubuntu
Focal Fossa (20.04) which no longer has `postgres-10` available, but
instead provides `postgres-12`.
@mbercx
Copy link
Member Author

mbercx commented Apr 16, 2021

Just noticed that my tests were failing in #4761:

https://github.com/aiidateam/aiida-core/pull/4761/checks?check_run_id=2362353306#step:5:63

Had the same issue for aiida-quantumespresso, see:

aiidateam/aiida-quantumespresso#674

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #4860 (9c8c451) into develop (5ab86cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4860   +/-   ##
========================================
  Coverage    79.58%   79.58%           
========================================
  Files          519      519           
  Lines        37093    37093           
========================================
  Hits         29517    29517           
  Misses        7576     7576           
Flag Coverage Δ
django 74.32% <ø> (ø)
sqlalchemy 73.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab86cc...9c8c451. Read the comment docs.

@greschd
Copy link
Member

greschd commented Apr 16, 2021

Why don't we just remove the version and install postgresql instead? Should work on both Ubuntu versions AFAICT, and it matches our install guide: https://aiida.readthedocs.io/projects/aiida-core/en/latest/intro/install_system.html#intro-get-started-system-wide-install

@csadorf
Copy link
Contributor

csadorf commented Apr 16, 2021

@mbercx I like @greschd ' suggestion, can you try that?

Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I'd suggest that we pin all dependencies in our CI workflows, but in this case I'm inclined to follow @greschd ' suggestion to install the default version. At the very least we should do that for the test-install workflow which should as closely as possible resemble our installation instructions on the docs.

@mbercx mbercx requested a review from csadorf April 16, 2021 15:55
@mbercx mbercx changed the title CI: use postgres-12 since update to Ubuntu Focal 20.04 CI: install default postgresql instead of specific version Apr 17, 2021
@mbercx
Copy link
Member Author

mbercx commented Apr 17, 2021

Thanks for the comments @greschd and @csadorf! Have made the suggested adjustment 👍

@csadorf csadorf merged commit 2bb18e0 into aiidateam:develop Apr 19, 2021
@mbercx mbercx deleted the fix/postgres-12 branch April 19, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants