-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: install default postgresql
instead of specific version
#4860
Conversation
The CI configuration uses `ubuntu-latest` which recently became Ubuntu Focal Fossa (20.04) which no longer has `postgres-10` available, but instead provides `postgres-12`.
Just noticed that my tests were failing in #4761: Had the same issue for |
Codecov Report
@@ Coverage Diff @@
## develop #4860 +/- ##
========================================
Coverage 79.58% 79.58%
========================================
Files 519 519
Lines 37093 37093
========================================
Hits 29517 29517
Misses 7576 7576
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Why don't we just remove the version and install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I'd suggest that we pin all dependencies in our CI workflows, but in this case I'm inclined to follow @greschd ' suggestion to install the default version. At the very least we should do that for the test-install
workflow which should as closely as possible resemble our installation instructions on the docs.
postgres-12
since update to Ubuntu Focal 20.04postgresql
instead of specific version
The CI configuration uses
ubuntu-latest
which recently became UbuntuFocal Fossa (20.04) which no longer has
postgresql-10
available, butinstead provides
postgres-12
. Here we switch to using the defaultpostgresql
, which is line with our installation guide and works with bothversions of Ubuntu.