-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disregard old test repository quirks for migration #4954
Disregard old test repository quirks for migration #4954
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4954 +/- ##
===========================================
+ Coverage 80.11% 80.11% +0.01%
===========================================
Files 515 515
Lines 36665 36666 +1
===========================================
+ Hits 29369 29371 +2
+ Misses 7296 7295 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cheers @CasperWA, just to confirm there is not an analogous change required in the sqlalchemy migrations? |
well actually I guess I meant test for the sqlalchemy backend, since the actual change is in general utils, so I assume that applies to both |
Yeah, it seems the checks were done backend-agnostically here, which makes sense as it has nothing to do with the DB. But I'm unsure exactly what you mean otherwise here? Edit: Ah, I think you do want another unit test, but for the SQLAlchemy backend. Hmm, I don't think it's necessary, but I can set it up if you want, just to be absolutely sure? |
Yeh that was the point; I just initially noted there was a django named file, but not an sqla one lol. |
Mnjeh - you'd say so wouldn't you? 😏 😅 Anyway, I've made a test, but now I'm not remembering how to test the SQLAlchemy backend, what's the env var? |
Nevermind, I figurereded it out. I'm totally sticky brain. (But for real: |
An old test created a `.gitignore` file in the Node repository folder `path`, while also creating files under a `raw_input` folder. This adds a logic test for this specific edge-case, migrating the `raw_input` folder and ignoring the `path` folder for the specific Node. Fixes aiidateam#4910.
317b05f
to
b5ff789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge that bad boy!
An old test created a
.gitignore
file in the Node repository folderpath
, while also creating files under araw_input
folder.This adds a logic test for this specific edge-case, migrating the
raw_input
folder and ignoring thepath
folder for the specific Node.Fixes #4910.