fix verdi computer show tab completion

[unkcpz]

Got the following error when doing verdi computer show <tab>. This is a quick fix but just thinking when this change made in DbComputer, maybe other places also need to be take care of?

Traceback (most recent call last):                                                                                      
  File "/home/unkcpz/Projects/python-code/aiida_core/aiida/orm/implementation/querybuilder.py", line 399, in get_column 
    return getattr(alias, colname)                                                                                      
  File "/home/unkcpz/miniconda3/envs/aiida-core-dev/lib/python3.8/site-packages/sqlalchemy/orm/util.py", line 506, in __
getattr__                                                                                                               
    attr = getattr(target, key)                                                                                         
AttributeError: type object 'DbComputer' has no attribute 'name'
...
...
  File "/home/unkcpz/Projects/python-code/aiida_core/aiida/orm/querybuilder.py", line 1225, in _add_to_projections
    entity_to_project = self._get_projectable_entity(alias, column_name, attr_key, cast=cast)
  File "/home/unkcpz/Projects/python-code/aiida_core/aiida/orm/querybuilder.py", line 1199, in _get_projectable_entity
    entity = self._impl.get_column(column_name, alias)
  File "/home/unkcpz/Projects/python-code/aiida_core/aiida/orm/implementation/querybuilder.py", line 401, in get_column
    raise ValueError(
ValueError: name is not a column of aliased(DbComputer)
Valid columns are:
id
uuid
label
hostname
description
scheduler_type
transport_type
metadata

[sphuber]

Thanks @unkcpz . The change of DbComputer.name to DbComputer.label was done in #4882 . It should have updated all other places in the code that still used name but this one was clearly missed and it is not tested. It would be great if you could add a quick test for it. Note that I think therefore we should also project on label instead of the hostname, because that is essentially what was being projected originally.

[codecov]

Codecov Report

Merging #4962 (d46a75a) into develop (3214236) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #4962      +/-   ##
===========================================
+ Coverage    80.05%   80.06%   +0.01%     
===========================================
  Files          515      515              
  Lines        36611    36611              
===========================================
+ Hits         29307    29308       +1     
+ Misses        7304     7303       -1     

Flag	Coverage Δ
django	74.52% <100.00%> (+0.02%)	⬆️
sqlalchemy	73.44% <100.00%> (-<0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiida/cmdline/params/types/computer.py	81.82% <100.00%> (+2.28%)	⬆️
aiida/engine/daemon/client.py	75.13% <0.00%> (-1.01%)	⬇️
aiida/transports/plugins/local.py	81.80% <0.00%> (+0.26%)	⬆️
aiida/orm/utils/loaders.py	86.52% <0.00%> (+0.47%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3214236...d46a75a. Read the comment docs.

[unkcpz]

Thanks @sphuber. The test added and also refactoring the unit test to use pytest.

[unkcpz]

Well, seems run into pre-commit pylint warnings. Do we need to exclude tests/ in pre-commit-pylint?

[sphuber]

Thanks a lot for the test and refactoring @unkcpz . The tests should also be linted so it should not be added to the exclude list. The errors are easy to address though. I made three suggestions that show how to do it. Just the one of unused variables you should apply to the other locations in the code that pylint mentioned

[sphuber]

pylint: disable=redefined-outer-name

[sphuber]

Suggested change

	def setup_computers(clear_database_before_test):
	@pytest.mark.usefixtures('clear_database_before_test')
	def setup_computers():

[unkcpz]

Ah~oh, mark.usefixtures does not work on fixtures ;-) pytest-dev/pytest#977

[sphuber]

Suggested change

	entity_01, entity_02, entity_03 = setup_computers
	entity_01, _, _ = setup_computers

[unkcpz]

@sphuber thanks! It should be all right this time.