🐛 FIX: Initialising a Node with a User

[chrisjsewell]

So it appears that no one has ever tried to specifically set a user for a node (e.g. Data(user=another_user)) because, as you see from the diff, it would then try to call .backend_entity on the backend entity and fail.
Disappointing that mypy didn't pick this up in the type checking (perhaps there is a stricter setting that I haven't added)

cc @ltalirz as this came up with respect to the REST API (i.e. if we want to create a node for a specific user)

[sphuber]

Thanks @chrisjsewell . Straight forward enough, but since this wasn't caught by tests and is so basic, would be good to add a simple test for this.

[chrisjsewell]

but since this wasn't caught by tests and is so basic, would be good to add a simple test for this.

yeh yeh I knew you were going to say this 😛 Just wanted to quickly add the code change via github first, so I didn't forget

[chrisjsewell]

@sphuber I converted all of tests/orm/node/test_node.py to pytest and added some extra tests

[codecov]

Codecov Report

Merging #4977 (e1f8e7a) into develop (1bc9dbe) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #4977      +/-   ##
===========================================
+ Coverage    80.11%   80.12%   +0.01%     
===========================================
  Files          515      515              
  Lines        36673    36676       +3     
===========================================
+ Hits         29378    29382       +4     
+ Misses        7295     7294       -1     

Flag	Coverage Δ
django	74.59% <100.00%> (+0.01%)	⬆️
sqlalchemy	73.51% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiida/manage/tests/pytest_fixtures.py	93.34% <100.00%> (+0.28%)	⬆️
aiida/orm/nodes/node.py	96.29% <100.00%> (ø)
aiida/transports/plugins/local.py	81.66% <0.00%> (+0.26%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc9dbe...e1f8e7a. Read the comment docs.

[sphuber]

Thanks @chrisjsewell