Update plugin howto #5000
Update plugin howto #5000
Conversation
… files instead of code_blocks
+ revise prepare-for-submission section
…pler, moved all parser related methods into one file and small changes to documentation - mostly imports
There was a problem hiding this comment.
thanks @sudarshanv01 !
I've gone through the PR now; a couple of change requests
|
|
||
| :returns: an exit code, if parsing fails (or nothing if parsing succeeds) | ||
| """ | ||
| from aiida.orm import SinglefileData |
There was a problem hiding this comment.
Let's move this to the top
docs/source/howto/plugin_codes.rst
Outdated
| from aiida.engine import submit | ||
| result = engine.submit(DiffCalculation, **builder) |
There was a problem hiding this comment.
I think the original code is the correct one and this change should be reverted
|
Also note that there are currently pre-commit and docs build failures |
Co-authored-by: Leopold Talirz <leopold.talirz@gmail.com>
Co-authored-by: Leopold Talirz <leopold.talirz@gmail.com>
| spec.inputs['metadata']['options']['resources'].default = { | ||
| 'num_machines': 1, | ||
| 'num_mpiprocs_per_machine': 1, | ||
| } |
There was a problem hiding this comment.
is this not being autoformatted via the pre-commit hooks?
if it was, this would almost certainly change
There was a problem hiding this comment.
also, when modifying the code of the python scripts, please always check the corresponding text in the tutorial.
e.g. in this case the text expects these two lines to be after spec.output.
Codecov Report
@@ Coverage Diff @@
## develop #5000 +/- ##
========================================
Coverage 80.13% 80.13%
========================================
Files 515 515
Lines 36692 36692
========================================
Hits 29399 29399
Misses 7293 7293
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
No description provided.