🐛 FIX: BandsData matplotlib with NaN values
#5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `nanmin` and `nanmax` instead of the simple `min/max` ignores NaN values in the bands array and makes the matploblib plotter work for incomplete bands.
Codecov Report
@@ Coverage Diff @@
## develop #5024 +/- ##
===========================================
- Coverage 80.17% 80.17% -0.00%
===========================================
Files 515 515
Lines 36746 36746
===========================================
- Hits 29458 29457 -1
- Misses 7288 7289 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
unkcpz
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
@PhilippRue thanks! This looks good to me. See if others have more to comment.
chrisjsewell
changed the title
BandsData matplotlib with NaN values
|
cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BandsDatasupports usingnumpy.NaNvalues in the bands array which can be used to remove some parts of the bands or to fill up parts which might be out of a certain energy window.The matplotlib plotting functionality (
BandsData.show_mpl()) however does not work with NaN values when the limits for the plot are found.With
nanminandnanmaxinstead of the simplemin/maxignores NaN values in the bands array and makes the matplotlib plotter work for incomplete bands.