⬆️ UPDATE: pylint 2.11 #5167
Merged
⬆️ UPDATE: pylint 2.11 #5167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses new issue types: `consider-using-in`, `use-sequence-for-iteration`, `redundant-u-string-prefix`, `consider-iterating-dictionary`, `use-list-literal`, `use-dict-literal`, `global-variable-not-assigned`, `cell-var-from-loop`, `unspecified-encoding`. For now, `consider-using-f-string` is added to the ignore list, since there was too many to fix, and we already use flynt to catch most new issues.
Codecov Report
@@ Coverage Diff @@
## develop #5167 +/- ##
===========================================
- Coverage 80.93% 80.92% -0.00%
===========================================
Files 536 536
Lines 37054 37054
===========================================
- Hits 29986 29984 -2
- Misses 7068 7070 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
there is some weird (incorrect) errors, that don't actually get raise locally on my Mac, so I guess will just disable them for now. |
|
Opened pylint-dev/pylint#5131 for the |
|
cc @aiidateam/dependency-manager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses new issue types:
consider-using-in,use-sequence-for-iteration,redundant-u-string-prefix,consider-iterating-dictionary,use-list-literal,use-dict-literal,global-variable-not-assigned,cell-var-from-loop,unspecified-encoding.For now,
consider-using-f-stringis added to the ignore list, since there was too many to fix, and we already use flynt to catch most new issues.