Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOCS: Fix system-wide install instructions #5174

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Oct 11, 2021

Fixes #5173

Fix some faulty installation instructions for the pip installation path, as
well as some code-blocks that don't play nice with the sphinx-copybutton.

Additionally, add an important note regarding the version of the Python
executable used to set up the virtual environment which AiiDA will be installed
in.

Fix some faulty installation instructions for the `pip` installation path, as
well as some code-blocks that don't play nice with the `sphinx-copybutton`.

Additionally, add an `important` note regarding the version of the Python
executable used to set up the virtual environment which AiiDA will be installed
in.
@mbercx mbercx requested a review from csadorf October 11, 2021 09:31
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 👍

@mbercx
Copy link
Member Author

mbercx commented Oct 11, 2021

@chrisjsewell I guess the leftover tests don't run for documentation updates? Maybe we have to change the CI setup somehow, since now I have to use admin privileges to merge the PR.

@chrisjsewell
Copy link
Member

Maybe we have to change the CI setup

Not possible, you got admin privileges for a reason 😉

@mbercx mbercx merged commit ddad09c into aiidateam:develop Oct 11, 2021
@mbercx mbercx deleted the docs/5173/system-install branch October 11, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📚 Docs: Fix system-wide installation instructions
3 participants