-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👌 IMPROVE: Ensure QueryBuilder
is passed Backend
#5186
Conversation
This PR ensures core code always calls `QueryBuilder` with a specific `Backend`, as opposed to assuming the loaded `Backend`. This will allow for muliple backends to be used at the same time (for example aiida archives), for features including graph traversal and visualisation.
Codecov Report
@@ Coverage Diff @@
## develop #5186 +/- ##
===========================================
+ Coverage 81.01% 81.01% +0.01%
===========================================
Files 535 535
Lines 37376 37392 +16
===========================================
+ Hits 30275 30289 +14
- Misses 7101 7103 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed prior online, we might want to move to the concept of passing a Profile
instance around instead of Backend
as the profile concept is more intuitive to a user compared to the backend. However, this required some more discussion and we did more or less agree that having the possibility to pass one of the two explicitly for the querybuilder is necessary, so we are going to merge this PR as is. Thanks @chrisjsewell
This is a follow-up to #5186, to ensure `Graph` always uses the initialised `Backend`.
This is a follow-up to #5186, to ensure `Graph` always uses the initialised `Backend`.
This PR ensures core code always calls
QueryBuilder
with a specificBackend
, as opposed to assuming the loadedBackend
.This will allow for muliple backends to be used at the same time (for example aiida archives), for features including graph traversal and visualisation.