Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: AuthInfo use in QueryBuilder #5201

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Oct 27, 2021

Ensure AuthInfo can be properly queried for, fixing a bug in the metadata field translation.
Add with_authinfo to User joins.

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #5201 (6a272a4) into develop (5530589) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5201      +/-   ##
===========================================
+ Coverage    81.00%   81.00%   +0.01%     
===========================================
  Files          535      535              
  Lines        37404    37410       +6     
===========================================
+ Hits         30294    30301       +7     
+ Misses        7110     7109       -1     
Flag Coverage Δ
django 75.82% <66.67%> (+0.01%) ⬆️
sqlalchemy 74.92% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/orm/implementation/querybuilder.py 94.92% <ø> (ø)
...m/implementation/sqlalchemy/querybuilder/joiner.py 91.31% <100.00%> (+0.20%) ⬆️
...orm/implementation/sqlalchemy/querybuilder/main.py 84.80% <100.00%> (+0.06%) ⬆️
aiida/transports/plugins/local.py 81.41% <0.00%> (-0.25%) ⬇️
aiida/engine/daemon/client.py 76.27% <0.00%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5530589...6a272a4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant