Docs: improve the example in the scheduler errors topic #5240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example was advocating to simply check if any exit status was set on the node, however, it is probably better to check for specific exit codes that are known to occurr, such as the OOW and OOM errors that can be raised by the scheduler. The example is updated to give both examples and give some advice as to why the one would be used over the other.
unkcpz
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
Thanks! @sphuber Looks all good to me.
And It seems I made a mistake in aiidateam/aiida-quantumespresso#754 to compare exit_status with exit_codes object 🥲
|
Indeed, I missed that as well during the review, but realized when writing the docs that as written it probably it wouldn't work. Good to open a PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5239
The example was advocating to simply check if any exit status was set on
the node, however, it is probably better to check for specific exit
codes that are known to occurr, such as the OOW and OOM errors that can
be raised by the scheduler.
The example is updated to give both examples and give some advice as to
why the one would be used over the other.