📚 DOCS: finalize rename of verdi database migrate
#5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`verdi database migrate` was renamed to `verdi storage migrate` in a few places but a number of commands still mentioned the old command in their output. In addition, udpating tests to use the new command. Finally, the redirect from the deprecated `verdi database migrate` has an import error since it invokes a command that has changed name. (Not sure why this was not caught by the precommit tests?)
|
@ramirezfranciscof I made a draft PR because I tested it locally (by migrating my profile) but didn't run all tests yet. |
Codecov Report
@@ Coverage Diff @@
## develop #5246 +/- ##
===========================================
+ Coverage 81.38% 81.38% +0.01%
===========================================
Files 529 529
Lines 37008 37008
===========================================
+ Hits 30116 30117 +1
+ Misses 6892 6891 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
I'll fix the doc link in a separate PR |
chrisjsewell
changed the title
verdi database migrateverdi database migrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verdi database migratewas renamed toverdi storage migratein a few placesbut a number of commands still mentioned the old command in their output.
In addition, udpating tests to use the new command.
Finally, the redirect from the deprecated
verdi database migratehas an import error since it invokes a command that has changed name.
(Not sure why this was not caught by the precommit tests?)
Fixes #5245