Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 DOCS: add trove classifier for development status #5254

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Dec 7, 2021

aiida-core was missing the trove classifier for the development status.

@ltalirz ltalirz requested a review from chrisjsewell December 7, 2021 16:27
@chrisjsewell
Copy link
Member

chrisjsewell commented Dec 7, 2021

I would put it at the top, in alphabetical order 😬

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #5254 (6abb1d2) into develop (21efd99) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5254      +/-   ##
===========================================
- Coverage    81.39%   81.38%   -0.00%     
===========================================
  Files          529      529              
  Lines        37002    37002              
===========================================
- Hits         30113    30112       -1     
- Misses        6889     6890       +1     
Flag Coverage Δ
django 76.88% <ø> (-<0.01%) ⬇️
sqlalchemy 75.80% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/transports/plugins/local.py 81.41% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21efd99...6abb1d2. Read the comment docs.

@ltalirz ltalirz force-pushed the add-trove-classifier branch from d050b61 to fdb991f Compare December 7, 2021 16:53
@ltalirz
Copy link
Member Author

ltalirz commented Dec 7, 2021

Makes sense, done!

@chrisjsewell chrisjsewell changed the title docs: add trove classifier for development status 📚 DOCS: add trove classifier for development status Dec 7, 2021
@chrisjsewell
Copy link
Member

Ermm did you accidentally include another PR?

aiida-core was missing the trove classifier for the development status
@ltalirz ltalirz force-pushed the add-trove-classifier branch from fdb991f to 53cfc8e Compare December 7, 2021 17:23
@ltalirz
Copy link
Member Author

ltalirz commented Dec 7, 2021

sorry, I had some local changes lying around.

I should finally have managed to add this single line now ;-)

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge

@ltalirz ltalirz merged commit 053efee into aiidateam:develop Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants