Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/issue 5289 update peter evans create pull request action #5294

Merged

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Jan 7, 2022

Closes #5289.

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #5294 (873e2ea) into develop (995f254) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5294      +/-   ##
===========================================
- Coverage    81.51%   81.51%   -0.00%     
===========================================
  Files          530      530              
  Lines        37105    37105              
===========================================
- Hits         30242    30241       -1     
- Misses        6863     6864       +1     
Flag Coverage Δ
django 76.97% <ø> (ø)
sqlalchemy 75.97% <ø> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida/transports/plugins/local.py 81.41% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995f254...873e2ea. Read the comment docs.

@csadorf
Copy link
Contributor Author

csadorf commented Jan 11, 2022

@sphuber The relevant workflows (test-install) are succeeding.

@sphuber
Copy link
Contributor

sphuber commented Jan 11, 2022

Thanks @csadorf . I would prefer that we fix the CI first so all tests can finish correctly. So if you don't mind, I put this on hold until we have sorted out the problem with mypy and pymatgen.

@csadorf
Copy link
Contributor Author

csadorf commented Jan 11, 2022

Thanks @csadorf . I would prefer that we fix the CI first so all tests can finish correctly. So if you don't mind, I put this on hold until we have sorted out the problem with mypy and pymatgen.

Since this update has security implications, I'd rather merge it now.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @csadorf

@sphuber sphuber merged commit af5cd68 into develop Jan 13, 2022
@sphuber sphuber deleted the ci/issue-5289-update-peter-evans-create-pull-request-action branch January 13, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Workflow test-install.yml is using vulnerable action peter-evans/create-pull-request
2 participants