Tests: do not use /bin as folder in verdi code setup test
#5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most tests for `verdi code setup` have been defining `/bin/bash` as the executable since that should exist on most platforms. For remote codes this poses no problems as it is just the executable name that is stored. However, for a test storing it as a "local" code, this was causing the test to take in the order of minutes. The reason is that for local codes all files of the parent folder of the executable, i.e. `/bin`, are copied to the repository. To fix the problem, a temporary folder with a dummy executable is created instead.
|
Thanks a lot @sphuber ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most tests for
verdi code setuphave been defining/bin/bashas theexecutable since that should exist on most platforms. For remote codes
this poses no problems as it is just the executable name that is stored.
However, for a test storing it as a "local" code, this was causing the
test to take in the order of minutes. The reason is that for local codes
all files of the parent folder of the executable, i.e.
/bin, arecopied to the repository. To fix the problem, a temporary folder with a
dummy executable is created instead.