fix: delete configured computers

[ltalirz]

fix #5396

Deleting a configured computer resulted in an error, since the
associated Authinfo object was not deleted (instead, the "dbcomputer_id"
was set to null, which violated a not-null constraint).

Deleting computers was already tested, but not deleting a configured
computer. This is fixed as well.

[ltalirz]

@chrisjsewell Seems like the deletion test passes now.

Do I need to write a migration here?
Is there an automatic way of getting it?

[chrisjsewell]

Do I need to write a migration here?

No, relationships are at the ORM level (client-side), i.e. transient and not part of the database schema

Might be good to add two tests to tests/orm/test_authinfos.py, to specifically test that deleting a computer or user also removes any associated authinfos
(but don't try to delete the default user, because that may mess up subsequent tests)

[ltalirz]

While looking into this, I realized that there actually is no User.objects.delete - is there any way to delete a user?

If not should I be adding it in this PR?

[chrisjsewell]

is there any way to delete a user?

Not on the front-end (i.e. in aiida/orm/implementation/users.py)

I guess thats a bit of a wider discussion than this PR 😬
As mentioned above, we should probably not allow for the deletion of the default user for a profile, since that is a bit of a special case

[ltalirz]

is there any way to delete a user?

Not on the front-end (i.e. in aiida/orm/implementation/users.py)

I guess thats a bit of a wider discussion than this PR 😬 As mentioned above, we should probably not allow for the deletion of the default user for a profile, since that is a bit of a special case

Ok, then I guess it's enough if I add a test that deleting a computer also deletes the authinfo and leave the test deleting a user for another time.

[chrisjsewell]

👍

[chrisjsewell]

Cheers