ProfileManager: always clear storage in clear_profile
#5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to `_clear` on the storage in `ProfileManager.clear_profile` was conditional on it already having been loaded. However, sometimes the method may be called before the storage had already been loaded. This is the case, for example, for the `aiida_profile_clean` fixture, which is used by tests to start with an empty storage. Due to the conditional, in some cases the storage would not be emptied and the test would fail if the storage still contained data from a previous session.
chrisjsewell
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
_clearon the storage inProfileManager.clear_profilewas conditional on it already having been loaded. However, sometimes the
method may be called before the storage had already been loaded. This is
the case, for example, for the
aiida_profile_cleanfixture, which isused by tests to start with an empty storage. Due to the conditional, in
some cases the storage would not be emptied and the test would fail if
the storage still contained data from a previous session.