Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps: Remove --use-feature flag in pip install of CI #5703

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Oct 18, 2022

The tests job of the CI workflow used the --use-feature=2020-resolver flag in the pip install call to force using a specific package dependency resolver. We adopted this way back when pip introduced this new dependency resolver to be early-adopters to detect problems as soon as possible. In latest versions of pip this option is no longer available since the resolver is now the default, so we simply remove the flag.

The `tests` job of the CI workflow used the `--use-feature=2020-resolver`
flag in the `pip install` call to force using a specific package
dependency resolver. We adopted this way back when `pip` introduced this
new dependency resolver to be early-adopters to detect problems as soon
as possible. In latest versions of `pip` this option is no longer
available since the resolver is now the default, so we simply remove the
flag.
@sphuber sphuber requested a review from unkcpz October 18, 2022 09:24
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@sphuber sphuber merged commit 59aaa5c into aiidateam:main Oct 18, 2022
@sphuber sphuber deleted the fix/ci-pip-resolver branch October 18, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants