🔃 REFACTOR: Move Scheduler/Transport behind Client API

.github/workflows/tests_nightly.sh

@@ -13,4 +13,4 @@ verdi -p test_aiida run ${SYSTEM_TESTS}/test_containerized_code.py
 bash ${SYSTEM_TESTS}/test_polish_workchains.sh
 verdi daemon stop
 
-AIIDA_TEST_PROFILE=test_aiida pytest -v tests -m 'nightly'
+AIIDA_TEST_PROFILE=test_aiida pytest -v tests -m 'nightly' --timeout=200

.pre-commit-config.yaml

@@ -105,10 +105,6 @@ repos:
                 aiida/common/extendeddicts.py|
                 aiida/common/hashing.py|
                 aiida/common/utils.py|
-                aiida/engine/daemon/execmanager.py|
-                aiida/engine/processes/calcjobs/manager.py|
-                aiida/engine/processes/calcjobs/monitors.py|
-                aiida/engine/processes/calcjobs/tasks.py|
                 aiida/engine/processes/control.py|
                 aiida/engine/processes/functions.py|
                 aiida/engine/processes/ports.py|
@@ -120,7 +116,6 @@ repos:
                 aiida/manage/tests/main.py|
                 aiida/manage/tests/pytest_fixtures.py|
                 aiida/orm/comments.py|
-                aiida/orm/computers.py|
                 aiida/orm/implementation/storage_backend.py|
                 aiida/orm/nodes/caching.py|
                 aiida/orm/nodes/comments.py|
@@ -137,7 +132,6 @@ repos:
                 aiida/orm/utils/builders/computer.py|
                 aiida/orm/utils/calcjob.py|
                 aiida/orm/utils/node.py|
-                aiida/orm/utils/remote.py|
                 aiida/repository/backend/disk_object_store.py|
                 aiida/repository/backend/sandbox.py|
                 aiida/restapi/common/utils.py|

aiida/calculations/importers/arithmetic/add.py

@@ -21,9 +21,9 @@ def parse_remote_data(remote_data: RemoteData, **kwargs) -> Dict[str, Union[Node
         :returns: a dictionary with the parsed inputs nodes that match the input spec of the associated ``CalcJob``.
         """
         with NamedTemporaryFile('w+') as handle:
-            with remote_data.get_authinfo().get_transport() as transport:
+            with remote_data.get_client() as client:
                 filepath = Path(remote_data.get_remote_path()) / 'aiida.in'
-                transport.getfile(filepath, handle.name)
+                client.getfile(str(filepath), handle.name)
 
             handle.seek(0)
             data = handle.read()

aiida/calculations/monitors/base.py

@@ -4,22 +4,22 @@
 
 import tempfile
 
+from aiida.client import ComputeClientOpenProtocol
 from aiida.orm import CalcJobNode
-from aiida.transports import Transport
 
 
-def always_kill(node: CalcJobNode, transport: Transport) -> str | None:  # pylint: disable=unused-argument
+def always_kill(node: CalcJobNode, client: ComputeClientOpenProtocol) -> str | None:  # pylint: disable=unused-argument
     """Retrieve and inspect files in working directory of job to determine whether the job should be killed.
 
     This particular implementation is just for demonstration purposes and will kill the job as long as there is a
     submission script that contains some content, which should always be the case.
 
     :param node: The node representing the calculation job.
-    :param transport: The transport that can be used to retrieve files from remote working directory.
+    :param client: The client that can be used to retrieve files from remote working directory.
     :returns: A string if the job should be killed, `None` otherwise.
     """
     with tempfile.NamedTemporaryFile('w+') as handle:
-        transport.getfile('_aiidasubmit.sh', handle.name)
+        client.getfile('_aiidasubmit.sh', handle.name)
         handle.seek(0)
         output = handle.read()
 

aiida/client/__init__.py

@@ -0,0 +1,5 @@
+# -*- coding: utf-8 -*-
+"""Module containing compute clients."""
+from .protocol import ComputeClientOpenProtocol, ComputeClientProtocol
+
+__all__ = ['ComputeClientProtocol', 'ComputeClientOpenProtocol']