-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevOps: devcontainer update to use new docker stack #6139
Conversation
5ccca89
to
86e6917
Compare
4b93534
to
b02c557
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @unkcpz
The only concern I have is these four lines haven't been run before and they are supposed to give the right tag to the image when making the release to dockerhub. aiida-core/.github/workflows/docker-push.yml Lines 67 to 70 in 61828e2
Can you give it double-check the matching pattern is all good? I am totally fine with |
Amendment to #6139, for unknown reason, docker pull is failed for docker.io on this repository. Using the docker registry ghcr.io works fine.
@unkcpz I am not familiar with the syntax for those acxtions, but our tags do follow the pattern |
The effect can be see from https://github.com/unkcpz/aiida-core/tree/fix/xx/devcontainer-new-docker