SqliteDosStorage: Implement the storage backup
#6370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
feature/sqlite-dos-storage-backup
branch
from
3bffcf3 to
28fede4
Compare
sphuber
added
the
priority/critical-blocking
sphuber
force-pushed
the
feature/sqlite-dos-storage-backup
branch
from
28fede4 to
de0ed6b
Compare
The `PsqlDosBackend` storage plugin was manually performing the check whether the profile that was about to be backed up was not locked. From a safety consideration, it is better to perform this check in the base class so that it is not accidentally forgotten by a plugin.
sphuber
force-pushed
the
feature/sqlite-dos-storage-backup
branch
2 times, most recently
from
4bf8fa4 to
99a3bed
Compare
danielhollas
approved these changes
May 7, 2024
There was a problem hiding this comment.
I took this for a spin, since I wanted to try the new verdi storage backup command. Works great!
The implementation here seems pretty straightforward, thank you for doing the refactoring that makes it clearer. I only have some nits, my main question is about the profile locking -- is the profile locked when the backup is running?
sphuber
force-pushed
the
feature/sqlite-dos-storage-backup
branch
from
99a3bed to
caf876c
Compare
danielhollas
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.