Docker Image: Fix release tag in publish workflow #6520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
force-pushed
the
docker-fix-tag
branch
from
1ddbd02
to
b66389b
Compare
danielhollas
changed the title
|
Looks good to me. @unkcpz can you also have a quick check to see that this makes sense? Thanks |
unkcpz
approved these changes
Jul 5, 2024
| if: ${{ github.ref_type == 'tag' && startsWith(github.ref_name, 'v') }} | ||
| run: | | ||
| tag="${{ github.ref_name }}" | ||
| echo "AIIDA_VERSION=${tag#v}" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
I assume ${tag#v} is drop v in front, correct?
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
The `AIIDA_VERSION` variable was no longer present in the env. It is now retrieved separately from the tag version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6510.
Looks like this works, see this test run which generated the aiida-2.6.x-test tag on ghcr.io.