Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a single CalcJob with a transport request #6596

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Oct 30, 2024

This maybe a good solution for #6595 to keep the SSH open for the lifetime of a single CalcJob.

@unkcpz unkcpz requested a review from GeigerJ2 October 30, 2024 15:13
@unkcpz unkcpz force-pushed the fix/6596/another-way-around-to-reuse-ssh-question-mark branch from b93820c to d9fae85 Compare October 30, 2024 15:36
@GeigerJ2
Copy link
Contributor

GeigerJ2 commented Nov 4, 2024

Thanks for the great discussions on this topic last week, @unkcpz, as well as for looking into it and making the PR. I'm not sure if this is really an ideal solution, though, as it would keep the transport context manager open for the full duration of the CalcJob, which might be hours or days while the job is running and task_monitor_job is being regularly executed.
Wondering what @giovannipizzi thinks about this. For now, it might be easiest to just decrease the DEFAULT_SAFE_OPEN_INTERVAL and call it a day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants