-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies: Restrict Python to strictly below 3.13 #6603
Conversation
Recstrict Python version ito strictly below 3.13 until we have resolved the dependency issues in PR aiidateam#6600.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6603 +/- ##
==========================================
+ Coverage 77.51% 77.87% +0.37%
==========================================
Files 560 567 +7
Lines 41444 42120 +676
==========================================
+ Hits 32120 32796 +676
Misses 9324 9324 ☔ View full report in Codecov by Sentry. |
Not saying we shouldn't do this, but is this really necessary? Our own code is compatible with Python 3.13. It is just that certain dependencies aren't. Adding this limitation is not going to do much then, right? Especially not if we are not going to release it soon. By the time we would release it we will probably be compatible with 3.13 anyway and we would have to remove it again. So far we have never imposed an explicit limit and it has never caused issues. I am also not aware that this is recommended as a best practice by the PyPA. |
Yeah, I think this is actually discouraged, to the point where for example |
Read the same astral-sh/uv#8374 (comment) There is a huge discussion about it, but I don't see any result comig from it |
Since we agreed for the release to not include it, this can be closed. If this comes up again as a general discussion one can open an issue. |
The main issue is, even if you did include it in the release it would be
kind of pointless, since the resolver would simply backtrack to the
previous version that did not include the constraint. :-/
Dne st 6. 11. 2024 6:38 uživatel Alexander Goscinski <
***@***.***> napsal:
… Since we agreed for the release to not include it, this can be closed. If
this comes up again as a general discussion one can open an issue.
—
Reply to this email directly, view it on GitHub
<#6603 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIY64PMORNW2GL22ROR5JLZ7G2PLAVCNFSM6AAAAABREU3V42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJYHAZDOOJTGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
☝️ That is exactly it. |
Another interesting and well laid out point of view just for reference: https://iscinumpy.dev/post/bound-version-constraints/ |
Recstrict Python version ito strictly below 3.13 until we have resolved the dependency issues in PR #6600.