Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add the cp2k-output-tools parser #133

Merged
merged 4 commits into from
Apr 19, 2021
Merged

parser: add the cp2k-output-tools parser #133

merged 4 commits into from
Apr 19, 2021

Conversation

dev-zero
Copy link
Contributor

No description provided.

yakutovicha
yakutovicha reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dev-zero, overall, good to go. Just a couple of minor things.

setup.json Show resolved Hide resolved
aiida_cp2k/parsers/__init__.py Outdated Show resolved Hide resolved
aiida_cp2k/parsers/__init__.py Outdated Show resolved Hide resolved
dev-zero and others added 2 commits April 19, 2021 11:15
@dev-zero @yakutovicha
Update aiida_cp2k/parsers/__init__.py
a98352b 
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
@dev-zero @yakutovicha
Update aiida_cp2k/parsers/__init__.py
0c5091f 
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
@yakutovicha yakutovicha self-requested a review April 19, 2021 09:40
yakutovicha
yakutovicha approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dev-zero!

@yakutovicha yakutovicha merged commit b4127c3 into aiidateam:develop Apr 19, 2021
@dev-zero dev-zero deleted the feature/cp2k-output-tools-parser branch April 21, 2021 12:35
hdsassnick pushed a commit to hdsassnick/aiida-cp2k that referenced this pull request Apr 26, 2021
@dev-zero
Parser: add the cp2k-output-tools parser (aiidateam#133).
b846f47
@yakutovicha yakutovicha mentioned this pull request Jul 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakutovicha yakutovicha yakutovicha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev-zero @yakutovicha