Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to fix issue #158 #159

Merged
merged 10 commits into from
Jun 10, 2022
Merged

Proposal to fix issue #158 #159

merged 10 commits into from
Jun 10, 2022

Conversation

mkrack
Copy link
Contributor

@mkrack mkrack commented Jun 9, 2022

fixes #158

Make sure the code is compatible with Python 3.10

mkrack added 2 commits June 9, 2022 14:10
Consider change of the collections interface in Python 3.10 and keep the code backwards compatible
@yakutovicha yakutovicha self-requested a review June 10, 2022 12:03
Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mkrack! I think we can go simple here, see my comment below.

aiida_cp2k/utils/workchains.py Outdated Show resolved Hide resolved
@yakutovicha
Copy link
Contributor

It looks like the new versions of the checks brought up too many issues. I propose to undo the changes to the setup.json file and I fix it in the next PR.

@mkrack
Copy link
Contributor Author

mkrack commented Jun 10, 2022

It looks like the new versions of the checks brought up too many issues. I propose to undo the changes to the setup.json file and I fix it in the next PR.

Indeed, the new pylint version detects tons of new issues. Though these changes will certainly improve the code quality, it will be some work to fix all these issues.

@yakutovicha
Copy link
Contributor

yakutovicha commented Jun 10, 2022

It looks like the new versions of the checks brought up too many issues. I propose to undo the changes to the setup.json file and I fix it in the next PR.

Indeed, the new pylint version detects tons of new issues. Though these changes will certainly improve the code quality, it will be some work to fix all these issues.

yeah, I will address it in a new PR, right after releasing a new version of the plugin

setup.json Outdated Show resolved Hide resolved
Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep the setup.json intact. I will modify it in a new PR and will release the 1.5.0 version.

setup.json Outdated Show resolved Hide resolved
@yakutovicha yakutovicha self-requested a review June 10, 2022 14:14
Copy link
Contributor

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mkrack
Copy link
Contributor Author

mkrack commented Jun 10, 2022

@yakutovicha Thank you for your support. We are fine with a new aiida_cp2k sub-release which will work with the upcoming CP2K release end of June also with Python 3.10.

@yakutovicha yakutovicha enabled auto-merge (squash) June 10, 2022 14:19
@yakutovicha yakutovicha merged commit 92776a9 into aiidateam:develop Jun 10, 2022
@yakutovicha
Copy link
Contributor

@mkrack I've just released a new version of the plugin: https://github.com/aiidateam/aiida-cp2k/releases/tag/v1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AiiDA-CP2K does not work with Python 3.10
2 participants