-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to fix issue #158 #159
Conversation
Consider change of the collections interface in Python 3.10 and keep the code backwards compatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mkrack! I think we can go simple here, see my comment below.
It looks like the new versions of the checks brought up too many issues. I propose to undo the changes to the |
Indeed, the new pylint version detects tons of new issues. Though these changes will certainly improve the code quality, it will be some work to fix all these issues. |
yeah, I will address it in a new PR, right after releasing a new version of the plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep the setup.json intact. I will modify it in a new PR and will release the 1.5.0 version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@yakutovicha Thank you for your support. We are fine with a new aiida_cp2k sub-release which will work with the upcoming CP2K release end of June also with Python 3.10. |
@mkrack I've just released a new version of the plugin: https://github.com/aiidateam/aiida-cp2k/releases/tag/v1.5.0 |
fixes #158
Make sure the code is compatible with Python 3.10