Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby propose a new version of the
ScfHubbardWorkChain
, which allows to compute self-consistently U and, also, U+V. The implementation follows directly from the one already proposed in the previous versions and with the new outline proposed in #17 . It essentially merges #13 and add the check needed for the self-consistent run.The changes concern:
hubbard_file
: the same as in A newSelfConsistentHubbardVWorkChain
#13; a validation function has been also added for dumbest-user-of-the-year (could be also improved).hubbard_start
: solve the issue of the 'how-can-I-find-the-indices' when doing the very first hubbard U+V run, so to have a similar input to the one of only hubbard U; a calcfunction has been added as well to reorder the hubbard atoms, which otherwise would make hp.x to crash and an other one to make the transition hubbard_start --> qe input. It will be "override" ifhubbard_file
is specified.tolerance
-->tolerance_u
tolerance_v
: self-explanatory.: you may want to skip the first relaxation if
meta_convergence == True` (i.e. doing sc run)cut_on_file
: could be useful if one wants to delete some too low values on the parameters file; NOT implemented and I don't know if it is useful. To be discussed.create_hubbard_v_from_distance
: makes the transition hubbard_start --> qe input; it is a calcfunction. The name is in line with the one of aiida-qe for kpoints.set_tot_magnetization
: allows to avoid the 'non-integer-value' issue for magnetic insulators; if a 'hard-coded' threshold is exceeded, it will stop the run.SelfConsistentHubbardVWorkChain
#13, the ones @MackeEric suggested, such as a new input for doing more the one hp.x calculation, etc...