PpParser: fix whitespace bug in the parse_gnuplot2D method
#534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was assuming that a line either contained valid data or was completely empty, in which case it is skipped. However, sometimes the code can produce empty lines with whitespace, such as spaces, which would crash the code. Stripping the line before further processing solves the problem. Since this bug relies on whitespace in the test data file, it was not being caught, because the pre-commit would strip trailing whitespace. That is why we reintroduce the whitespace manually and add any files with a file suffix that ends in `out` in the `tests` folder to the exclude list so it is not automatically removed on commit.
greschd
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531
The code was assuming that a line either contained valid data or was
completely empty, in which case it is skipped. However, sometimes the
code can produce empty lines with whitespace, such as spaces, which
would crash the code. Stripping the line before further processing
solves the problem.
Since this bug relies on whitespace in the test data file, it was not
being caught, because the pre-commit would strip trailing whitespace.
That is why we reintroduce the whitespace manually and add any files
with a file suffix that ends in
outin thetestsfolder to theexclude list so it is not automatically removed on commit.