Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PwBaseWorkChain: do no assume output_band exists in band sanity check #544

Merged
merged 1 commit into from
Aug 6, 2020

Commits on Aug 6, 2020

  1. PwBaseWorkChain: do no assume output_band exists in band sanity c…

    …heck
    
    The `output_band` output of the `PwCalculation` is optional and, for
    example, when the setting `no_bands=True`, the band files will not be
    retrieved and consequentially not parsed. The process handler checking
    the bands `sanity_check_insufficient_bands`, however, assumed the output
    node is always there. This is changed to simply skip the check if the
    node is not there.
    
    Note that we do not check in the workchain whether the output should
    have been there, because the sanity check is only triggered for
    successful calculations, and if the output should have been there, the
    calculation should have been failed. If this is not the case, that is a
    bug in the parser and should be addressed there.
    sphuber committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    5b37f3b View commit details
    Browse the repository at this point in the history