Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to run a NamelistCalculation using symlinks to the parent_folder #555

Merged
merged 19 commits into from
Sep 22, 2020

Conversation

Crivella
Copy link
Contributor

In most use-cases, the calculations that are a subclass of NamelistCalculation, are used for post-processing that only reads data from the ./out/ folder of a scf/nscf calculation.

I find it useful to have the option of symlinking the ./out/ folder instead of straight out copying it as it avoids, in some cases, to have to copy 10s to 100s of GB of data, slowing down the starting of the job, and having to clear the remote_data afterwards to avoid huge disk consumption on the cluster.

With this pull request, the option to symlink the ./out/ folder is by default off (to be consistent with older inputs) and is turned on by specifying 'PARENT_FOLDER_SYMLINK': True in the settings input Dict node.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Crivella , this looks fine. Could you just please add a quick test?

@Crivella Crivella force-pushed the feature-NamelistCalc_with_symlinks branch from d9eea2d to 517d4bf Compare September 19, 2020 23:31
@Crivella
Copy link
Contributor Author

@sphuber
I have added the tests to the pw2gw Calcjob tests (now a parametrized fixture runs the test with and w/o the symlynk option)

@sphuber sphuber merged commit 59b957a into aiidateam:develop Sep 22, 2020
@sphuber
Copy link
Contributor

sphuber commented Sep 22, 2020

Thanks a lot @Crivella

@Crivella Crivella deleted the feature-NamelistCalc_with_symlinks branch October 6, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants