Remove duplicate line of setting cmdline arguments #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you're right, but the tests explicitly test the calcinfo. Maybe the tests need to be adapted, but I'll let @sphuber give his opinion on this. |
|
It should indeed be on the The tests are just checking the wrong object and because of the duplicated line they are actually passing. |
sphuber
pushed a commit
that referenced
this pull request
Nov 17, 2020
…585) It should be set on `CodeInfo` but was by accident also set on the `CalcInfo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cmdline_paramsshould be incodeinfo, notcalcinfo, am I right?