Pp parser memory fix #587
Merged
Pp parser memory fix #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greschd
reviewed
Oct 15, 2020
sphuber
approved these changes
Oct 15, 2020
|
Thanks @eimrek ! |
sphuber
pushed a commit
that referenced
this pull request
Oct 21, 2020
Before, the content of all retrieved files was loaded into memory and then parsed. For big calculations this can quickly run up the RAM required even though not necessary. By parsing the raw data as soon as its read and then deleting the raw data from memory, the memory footprint is reduced significantly. Cherry-picked from 95586d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR considerably reduces the memory usage of the pp.x parser. Before, all the retrieved files were loaded into memory and then parsed. This quickly ate up all the RAM and made our system crash for some of our use cases (e.g. we were parsing many orbital cubes files). Now parsing happens right after each retrieved file is read (and the memory is freed when the next retrieved file is read).