PwRelaxWorkChain: add tests for relax_type in generator overrides
#631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get_builder_from_protocol` method was not yet tested with respect to defining a `relax_type` in the `overrides` and make sure that the correct value is set on the builder that is returned.
sphuber
force-pushed
the
fix/relax-type
branch
from
e2e9317
to
3f9d2da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_builder_from_protocolmethod was not yet tested with respectto defining a
relax_typein theoverridesand make sure that thecorrect value is set on the builder that is returned.